This revision was automatically updated to reflect the committed changes.
Closed by commit rC343230: [OpenMP] Improve search for libomptarget-nvptx
(authored by Hahnfeld, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51686
Files:
include/clang/Driver/Options.td
lib/Driver
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D51686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:665
+// Add path to lib / lib64 folder.
+SmallString<256> DefaultLibPath =
Hahnfeld wrote:
> ABataev wrote:
> > You're changing the order of the lookup for the paths. Is this int
Hahnfeld updated this revision to Diff 167250.
Hahnfeld marked 2 inline comments as done.
Hahnfeld added a comment.
Add `const` per review comments.
https://reviews.llvm.org/D51686
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Ind
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:665
+// Add path to lib / lib64 folder.
+SmallString<256> DefaultLibPath =
ABataev wrote:
> You're changing the order of the lookup for the paths. Is this intended? If
> so, you
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:515
+ if (Arg *A = Args.getLastArg(options::OPT_libomptarget_nvptx_path_EQ))
+CmdArgs.push_back(Args.MakeArgString(Twine("-L") + A->getValue()));
+
`const Arg *A`
Co
Hahnfeld added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D51686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld created this revision.
Hahnfeld added reviewers: gtbercea, ABataev.
Herald added subscribers: cfe-commits, guansong.
When looking for the bclib Clang considered the default library
path first while it preferred directories in LIBRARY_PATH when
constructing the invocation of nvlink. The la
