dnsampaio added a comment.
In https://reviews.llvm.org/D51683#1226329, @joerg wrote:
> Correct. The protected name is double underscore as both suffix and prefix.
Ok, fixed. Cheers.
https://reviews.llvm.org/D51683
___
cfe-commits mailing list
cfe
joerg added a comment.
Correct. The protected name is double underscore as both suffix and prefix.
https://reviews.llvm.org/D51683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jgreenhalgh added inline comments.
Comment at: cfe/trunk/utils/TableGen/NeonEmitter.cpp:2412
- OS << "#define __ai static inline __attribute__((__always_inline__, "
+ OS << "#define __ai static __inline __attribute__((__always_inline__, "
"__nodebug__))\n\n";
---
dmgreen added a comment.
These new changes look good to me.
If you are updating things like this, it's often better to create a new Phab
review so it's easier to see it's a new thing (or, in cases like this where the
changes are simple and just test updates, they often don't need review). Eithe
dnsampaio updated this revision to Diff 164199.
https://reviews.llvm.org/D51683
Files:
test/Headers/arm-fp16-header.c
test/Headers/arm-neon-header.c
Index: test/Headers/arm-neon-header.c
===
--- test/Headers/arm-neon-header.c
+
dnsampaio updated this revision to Diff 164196.
dnsampaio added a comment.
Fix test march triple.
https://reviews.llvm.org/D51683
Files:
test/Headers/arm-fp16-header.c
test/Headers/arm-neon-header.c
Index: test/Headers/arm-neon-header.c
dnsampaio added inline comments.
Comment at: cfe/trunk/utils/TableGen/NeonEmitter.cpp:2412
- OS << "#define __ai static inline __attribute__((__always_inline__, "
+ OS << "#define __ai static __inline __attribute__((__always_inline__, "
"__nodebug__))\n\n";
-
joerg added inline comments.
Comment at: cfe/trunk/utils/TableGen/NeonEmitter.cpp:2412
- OS << "#define __ai static inline __attribute__((__always_inline__, "
+ OS << "#define __ai static __inline __attribute__((__always_inline__, "
"__nodebug__))\n\n";
-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341475: Fix arm_neon.h and arm_fp16.h generation for
compiling with std=c89 (authored by dnsampaio, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Repository:
rC Clang
https://reviews.llvm.org/D51683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
dnsampaio created this revision.
dnsampaio added reviewers: pbarrio, SjoerdMeijer.
Herald added a reviewer: javed.absar.
Herald added subscribers: cfe-commits, chrib, kristof.beyls.
The **inline** attribute is not valid for C standard 89. Replace the argument
in the generation of header files wit
11 matches
Mail list logo
