This revision was automatically updated to reflect the committed changes.
Closed by commit rL341797: [clangd] Fix async index loading (from r341376).
(authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51674?vs=1640
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall updated this revision to Diff 164012.
sammccall added a comment.
Don't load index asynchronously if -run-synchronously is passed.
Nothing needs this today, but it's less surprising behavior.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51674
Files:
clangd/tool/Cl
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
This wasn't actually async (due to std::future destructor blocking).
If it were, we would have clean shutdown issues if main returned
an
