This revision was automatically updated to reflect the committed changes.
Closed by commit rL343990: [CMake] Link to compiler-rt if
LIBUNWIND_USE_COMPILER_RT is ON. (authored by cdavis, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51657
cdavis5x updated this revision to Diff 168687.
cdavis5x added a comment.
- Detect libgcc.
Repository:
rUNW libunwind
https://reviews.llvm.org/D51657
Files:
cmake/config-ix.cmake
src/CMakeLists.txt
Index: src/CMakeLists.txt
===
mstorsjo added inline comments.
Comment at: src/CMakeLists.txt:60
+ append_if(libraries LIBUNWIND_HAS_GCC_S_LIB gcc_s)
+ list(APPEND libraries gcc)
+endif()
I'm a little suspicious of this line, of forcibly linking against libgcc here,
even if we might not hav
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good, sorry for the delay.
Repository:
rUNW libunwind
https://reviews.llvm.org/D51657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
cdavis5x added a comment.
Ping.
Repository:
rUNW libunwind
https://reviews.llvm.org/D51657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cdavis5x added a comment.
Ping.
Repository:
rUNW libunwind
https://reviews.llvm.org/D51657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cdavis5x created this revision.
cdavis5x added a reviewer: beanz.
Herald added subscribers: cfe-commits, chrib, christof, mgorny, dberris.
If `-nodefaultlibs` is given, we weren't actually linking to it. This
was true irrespective of passing `-rtlib=compiler-rt` (see previous
patch). Now we explic
