sammccall added a comment.
I think you're right - this isn't actually asynchronous (I didn't manage to
test that!), and if it were it'd interfere with clean shutdown.
I think both issues can be addressed by assigning the future to a variable
scoped to main. Will send a patch.
Repository:
rL
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp:287
+StaticIdx.reset(Placeholder = new
SwapIndex(llvm::make_unique()));
+runAsync([Placeholder] {
+ if (auto Idx = loadIndex(YamlSymbolFile))
Wouldn'
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341376: [clangd] Load static index asynchronously, add
tracing. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51638?
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg. Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Like https://reviews.llvm.org/D51475 but simplified based on recent patches.
While here, clarify that loadIndex() takes a filename, not
