This revision was automatically updated to reflect the committed changes.
Closed by commit rL341369: [clangd] Move buildStaticIndex() to SymbolYAML
(authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51626?vs=163823&i
kbobyrev updated this revision to Diff 163823.
kbobyrev marked 3 inline comments as done.
kbobyrev added a comment.
Rebase and resolve comments
https://reviews.llvm.org/D51626
Files:
clang-tools-extra/clangd/index/SymbolYAML.cpp
clang-tools-extra/clangd/index/SymbolYAML.h
clang-tools-extr
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/SymbolYAML.cpp:193
+ auto Slab = symbolsFromYAML(Buffer.get()->getBuffer());
+ SymbolSlab::Builder SymsBuilder;
+ for
kbobyrev updated this revision to Diff 163797.
kbobyrev added a comment.
Move function documentation to the header file.
https://reviews.llvm.org/D51626
Files:
clang-tools-extra/clangd/index/SymbolYAML.cpp
clang-tools-extra/clangd/index/SymbolYAML.h
clang-tools-extra/clangd/tool/ClangdMai
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
`buildStaticIndex()` is used by two other tools that I'm building, now it's
useful outside of `tool/ClangdMain.cpp`.
https://reviews.llvm.o
