This revision was automatically updated to reflect the committed changes.
Closed by commit rL341322: [clangd] Avoid crashes in override completions
(authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51598
Files:
cla
ilya-biryukov added inline comments.
Comment at: unittests/clangd/CodeCompleteTests.cpp:1770
+ // Check the completions call does not crash.
+ completions(R"cpp(
+struct Base {
ioeric wrote:
> ilya-biryukov wrote:
> > Was wondering if testing for crashes LG
ioeric added inline comments.
Comment at: unittests/clangd/CodeCompleteTests.cpp:1770
+ // Check the completions call does not crash.
+ completions(R"cpp(
+struct Base {
ilya-biryukov wrote:
> Was wondering if testing for crashes LG this way, or adding more
ilya-biryukov added inline comments.
Comment at: unittests/clangd/CodeCompleteTests.cpp:1770
+ // Check the completions call does not crash.
+ completions(R"cpp(
+struct Base {
Was wondering if testing for crashes LG this way, or adding more assertions
mig
ilya-biryukov created this revision.
ilya-biryukov added reviewers: kadircet, ioeric, hokein, sammccall.
Herald added subscribers: arphaman, jkorous, MaskRay.
NamedDecl::getName cannot be called on non-identifier names.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51598
Files
