This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341065: [clangd] Report position of opening paren in
singature help (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51437?vs=163286&id=163317#toc
Repository
ilya-biryukov added inline comments.
Comment at: unittests/clangd/CodeCompleteTests.cpp:914
+TEST(SignatureHelpTest, OpeningParen) {
+ Annotations Code(R"cpp(
sammccall wrote:
> Hmm, I think this test would be easier to follow if tests 1-5 were written
> sepa
ilya-biryukov updated this revision to Diff 163286.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Clarify the docs, add example.
- Parse each test separately.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51437
Files:
clangd/CodeComplete.cp
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/Protocol.h:832
+
+ /// Position of the opening paren of the argument list.
+ /// This is a clangd-specific extension, it is only available via
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric.
ilya-biryukov added a dependency: D51436: [CodeComplete] Report location of
opening parens for signature help.
ilya-biryukov updated this revision
ilya-biryukov updated this revision to Diff 163116.
ilya-biryukov added a comment.
- Format the code
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51437
Files:
clangd/CodeComplete.cpp
clangd/Protocol.h
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeC
