This revision was automatically updated to reflect the committed changes.
Closed by commit rL341077: [HIP] Add -fvisibility hidden option to clang
(authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51434?vs=163196&id=
yaxunl added inline comments.
Comment at: lib/Driver/ToolChains/HIP.cpp:256
+CC1Args.append({"-fvisibility", "hidden"});
}
arsenm wrote:
> arsenm wrote:
> > yaxunl wrote:
> > > arsenm wrote:
> > > > We should probably start subclassing the HIP toolchain fr
arsenm added inline comments.
Comment at: lib/Driver/ToolChains/HIP.cpp:256
+CC1Args.append({"-fvisibility", "hidden"});
}
arsenm wrote:
> yaxunl wrote:
> > arsenm wrote:
> > > We should probably start subclassing the HIP toolchain from AMDGPU and
> > > s
arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Driver/ToolChains/HIP.cpp:256
+CC1Args.append({"-fvisibility", "hidden"});
}
yaxunl wrote:
> arsenm wrote:
> > We should probably
yaxunl added inline comments.
Comment at: lib/Driver/ToolChains/HIP.cpp:256
+CC1Args.append({"-fvisibility", "hidden"});
}
arsenm wrote:
> We should probably start subclassing the HIP toolchain from AMDGPU and share
> more of this
I'd like to defer the re
arsenm added inline comments.
Comment at: lib/Driver/ToolChains/HIP.cpp:256
+CC1Args.append({"-fvisibility", "hidden"});
}
We should probably start subclassing the HIP toolchain from AMDGPU and share
more of this
https://reviews.llvm.org/D51434
_
yaxunl updated this revision to Diff 163196.
yaxunl added a comment.
Revised by Artem's comments.
https://reviews.llvm.org/D51434
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/hip-toolchain.hip
Index: test/Driver/hip-toolchain.hip
===
tra added inline comments.
Comment at: lib/Driver/ToolChains/HIP.cpp:255
+ options::OPT_fvisibility_ms_compat)) {
+CC1Args.push_back("-fvisibility");
+CC1Args.push_back("hidden");
Nit: You could collapse multiple `push_back` calls
yaxunl updated this revision to Diff 163186.
yaxunl retitled this revision from "[HIP] Add -amdgpu-internalize-symbols
option to opt" to "[HIP] Add -fvisibility hidden option to clang".
yaxunl edited the summary of this revision.
yaxunl added a comment.
Use -fvisibility hidden.
https://reviews.
