This revision was automatically updated to reflect the committed changes.
Closed by commit rC341963: [clang-cl, PCH] Support for /Yc and /Yu without
filename and #pragma hdrstop (authored by mikerice, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51391?vs=164698&id=164917#t
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm!
Please add a note to docs/ReleaseNotes.rst when landing.
https://reviews.llvm.org/D51391
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
mikerice updated this revision to Diff 164698.
mikerice marked an inline comment as done.
mikerice added a comment.
Updated to use two options: -pch-through-header-create and
-pch-through-header-use.
https://reviews.llvm.org/D51391
Files:
include/clang/Basic/DiagnosticDriverKinds.td
includ
hans added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:2862
+ Opts.PCHWithHdrStopCreate =
+ Args.getLastArgValue(OPT_pch_through_hdrstop_EQ) == "create";
Opts.PCHThroughHeader = Args.getLastArgValue(OPT_pch_through_header_EQ);
mikeri
mikerice added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:2862
+ Opts.PCHWithHdrStopCreate =
+ Args.getLastArgValue(OPT_pch_through_hdrstop_EQ) == "create";
Opts.PCHThroughHeader = Args.getLastArgValue(OPT_pch_through_header_EQ);
ha
mikerice updated this revision to Diff 163946.
mikerice marked 7 inline comments as done.
mikerice added a comment.
Thanks for the review. Updated based on comments from Hans.
https://reviews.llvm.org/D51391
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/Diagnostic
hans added a comment.
Very cool! I only have some minor comments.
Oh, and when it lands, you should probably add an update to
docs/ReleaseNotes.rst about it too.
Comment at: include/clang/Driver/CC1Options.td:613
+ HelpText<"Stop PCH generation after #pragma hdrstop. When u
mikerice created this revision.
mikerice added reviewers: thakis, hans.
With clang-cl, when the user specifies /Yc or /Yu without a header
the compiler uses a #pragma hdrstop in the main source file to
determine the end of the PCH. If a header is specified with /Yc or
/Yu #pragma hdrstop has no e
