[PATCH] D51385: [analyzer] InnerPointerChecker: Fix a segfault.

2018-08-30 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC341092: [analyzer] InnerPointerChecker: Fix a segfault when checking symbolic strings. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D51385?vs=162963&id=16338

[PATCH] D51385: [analyzer] InnerPointerChecker: Fix a segfault.

2018-08-30 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Ok, i'll get to the rest of the stuff a bit later (unless you pick it up). Repository: rC Clang https://reviews.llvm.org/D51385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D51385: [analyzer] InnerPointerChecker: Fix a segfault.

2018-08-28 Thread Reka Kovacs via Phabricator via cfe-commits
rnkovacs added a comment. > Return value of `dyn_cast_or_null` should be checked before use. Otherwise we > may put a null pointer into the map as a key and eventually crash in > `checkDeadSymbols`. Hm, so with the last `CallDescription` patch we removed some code here that essentially checked

[PATCH] D51385: [analyzer] InnerPointerChecker: Fix a segfault.

2018-08-28 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, baloghadamsoftware. Return value of `dyn_cast_or_null` should be checked before use. Otherwise we may put a nul