This revision was automatically updated to reflect the committed changes.
Closed by commit rL340828: [clangd] Switch to Dex by default for the static
index (authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51352?vs=
kbobyrev updated this revision to Diff 162865.
kbobyrev marked an inline comment as done.
https://reviews.llvm.org/D51352
Files:
clang-tools-extra/clangd/tool/ClangdMain.cpp
Index: clang-tools-extra/clangd/tool/ClangdMain.cpp
===
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:32
+// FIXME(kbobyrev): This option should be removed as Dex is now the default
+// static index.
-
kbobyrev updated this revision to Diff 162842.
kbobyrev marked 2 inline comments as done.
https://reviews.llvm.org/D51352
Files:
clang-tools-extra/clangd/tool/ClangdMain.cpp
Index: clang-tools-extra/clangd/tool/ClangdMain.cpp
===
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:32
static llvm::cl::opt
-UseDex("use-dex-index",
I think we should stick to the same option and just flip the default.
Introducing yet another option (that is going to
kbobyrev updated this revision to Diff 162840.
kbobyrev added a comment.
Run `clang-format`.
https://reviews.llvm.org/D51352
Files:
clang-tools-extra/clangd/tool/ClangdMain.cpp
Index: clang-tools-extra/clangd/tool/ClangdMain.cpp
==
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Dex is now mature enough to be used as the default static index. This patch
performs the switch
