[PATCH] D51332: [clang-tidy] Replace deprecated std::ios_base aliases

JonasToth closed this revision. JonasToth added a comment. Commited in https://reviews.llvm.org/rL343848. Thank you for the patch! https://reviews.llvm.org/D51332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D51332: [clang-tidy] Replace deprecated std::ios_base aliases

andobence updated this revision to Diff 168452. andobence added a comment. Rebased on top of master. I don't have commit rights. https://reviews.llvm.org/D51332 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp clang-tidy/modernize/Deprecate

[PATCH] D51332: [clang-tidy] Replace deprecated std::ios_base aliases

JonasToth added a comment. from my side is nothing outstanding https://reviews.llvm.org/D51332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51332: [clang-tidy] Replace deprecated std::ios_base aliases

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG once other comments are addressed. https://reviews.llvm.org/D51332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D51332: [clang-tidy] Replace deprecated std::ios_base aliases

JonasToth added a comment. LG from my side, please rebase that patch on top of master. Currently the Release Notes would conflict (and please sort the release note alphabetically). If the other reviewers do not say anything within a reasonable time it can be committed. Do you have commit rights

[PATCH] D51332: [clang-tidy] Replace deprecated std::ios_base aliases

JonasToth added a comment. And i forgot: Could you please run this over a real code base, if you know one that actually uses these types? I assume not so many code bases actually use these. https://reviews.llvm.org/D51332 ___ cfe-commits mailing li

[PATCH] D51332: [clang-tidy] Replace deprecated std::ios_base aliases

andobence marked 2 inline comments as done. andobence added inline comments. Comment at: clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp:34 + // provide any benefit to other languages, despite being benign. + if (!getLangOpts().CPlusPlus) +return; Jo

[PATCH] D51332: [clang-tidy] Replace deprecated std::ios_base aliases

andobence updated this revision to Diff 165453. andobence added a comment. Fixed everything mentioned in comments. https://reviews.llvm.org/D51332 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp clang-tidy/modernize/DeprecatedIosBaseAliase

[PATCH] D51332: [clang-tidy] Replace deprecated std::ios_base aliases

JonasToth added inline comments. Comment at: clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp:34 + // provide any benefit to other languages, despite being benign. + if (!getLangOpts().CPlusPlus) +return; Which standard supplies the replacement functi

[PATCH] D51332: [clang-tidy] Replace deprecated std::ios_base aliases

JonasToth added a comment. Hi andobence, thank you for the contribution. The check looks very good! Please add it to the release notes and synchronize the first line of the doc with the short sentence in the release notes describing what this check does. Comment at: clang-tid