[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

2018-09-13 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM https://reviews.llvm.org/D51297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

2018-09-13 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 165238. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51297 Files: clang-tools-extra/docs/clangd.rst Index: clang-tools-extra/docs/clangd.rst === --- clang-tools-extra

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

2018-09-13 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added inline comments. Comment at: clang-tools-extra/docs/clangd.rst:135 + +:program:`VSCode` provides `vscode-clangd +` ilya-biryukov wrote: > Maybe menti

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

2018-09-13 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clang-tools-extra/docs/clangd.rst:135 + +:program:`VSCode` provides `vscode-clangd +` Maybe mention it is published

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

2018-09-13 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 165228. kbobyrev added a comment. Create different sections for few editors, link web page with the complete list of LSP clients. https://reviews.llvm.org/D51297 Files: clang-tools-extra/docs/clangd.rst Index: clang-tools-extra/docs/clangd.rst ===

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

2018-09-13 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clang-tools-extra/docs/clangd.rst:114 + +There are multiple editors and plugins that are known to work with Clangd, such +as :program:`VSCode` and ``vscode-clangd`` extension, :program:`Emacs` and Thanks! I would be nice

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

2018-09-13 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/docs/clangd.rst:114 + +There are multiple editors and plugins that are known to work with Clangd, such +as :program:`VSCode` and ``vscode-cl

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

2018-09-13 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 165210. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51297 Files: clang-tools-extra/docs/clangd.rst Index: clang-tools-extra/docs/clangd.rst === --- clang-tools-extra

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

2018-09-13 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clang-tools-extra/docs/clangd.rst:111 +Editor Integration +== While we are here, would you mind including some other editors/plugins that are known to work with clangd (just so that people don't think v

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

2018-09-11 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 164841. kbobyrev added a comment. Outline the structure for "Editor Integration" section which is to be filled with other options later. https://reviews.llvm.org/D51297 Files: clang-tools-extra/docs/clangd.rst Index: clang-tools-extra/docs/clangd.rst

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

2018-09-11 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. In https://reviews.llvm.org/D51297#1228725, @ioeric wrote: > I also support having some instructions/pointers on editor integration. That > said, I think we should have a section "Editor integration" with a list of > editor clients that are known to work with clangd, i