This revision was automatically updated to reflect the committed changes.
Closed by commit rL341304: [clangd] Support multiple #include headers in one
symbol. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51291
File
ioeric updated this revision to Diff 163678.
ioeric added a comment.
- Document limitation for overload bundling.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51291
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/index/Index.cpp
clangd/index/Index.h
clan
ioeric updated this revision to Diff 163677.
ioeric added a comment.
- Rebase
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51291
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/index/Index.cpp
clangd/index/Index.h
clangd/index/Merge.cpp
clangd/index/Sy
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeComplete.cpp:396
+// Prefer includes that do not need edits (i.e. already exist).
+std::stable_sort(Completion.Includes.begin(), Comp
ioeric updated this revision to Diff 163351.
ioeric added a comment.
- Return all possible #includes in CodeComplete.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51291
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/index/Index.cpp
clangd/index/Index.h
sammccall added a comment.
- It would be useful for the C++ API (CodeCompletion struct) to provide the
includes/edits in ranked order, if possible. Frontends could experiment with
showing all the options.
- Still not sure that adding more complicated behavior to Code Complete (vs
just improving
ioeric updated this revision to Diff 163074.
ioeric added a comment.
- minor cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51291
Files:
clangd/CodeComplete.cpp
clangd/index/Index.cpp
clangd/index/Index.h
clangd/index/Merge.cpp
clangd/index/SymbolCollector.cpp
ioeric added a comment.
Thanks for the review! I reduced the scope of the patch. PTAL
Comment at: clangd/CodeComplete.cpp:1396
+ if (IndexResult && !IndexResult->IncludeHeaders.empty()) {
+for (const auto &P : IndexResult->IncludeHeaders)
+ AddWithInclude(
