[PATCH] D51260: Extract runCommandsInFile method

2018-08-30 Thread Stephen Kelly via Phabricator via cfe-commits
steveire marked 2 inline comments as done. steveire added a comment. Thanks, I fixed the issues before committing. This commit was a prerequisite to https://reviews.llvm.org/D51261 Repository: rL LLVM https://reviews.llvm.org/D51260 ___ cfe-comm

[PATCH] D51260: Extract runCommandsInFile method

2018-08-30 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL341144: Extract runCommandsInFile method (authored by steveire, committed by ). Herald added a subscriber: llvm-commits.

[PATCH] D51260: Extract runCommandsInFile method

2018-08-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. I'm not opposed to the changes here, but I am wondering what the benefits are to splitting this off into its own function? Comment at: clang-query/tool/ClangQuery.cpp:61 +int runCommandsInFile(const char* exeName, std::string const& fileName,

[PATCH] D51260: Extract runCommandsInFile method

2018-08-25 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. Herald added a subscriber: cfe-commits. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51260 Files: clang-query/tool/ClangQuery.cpp Index: clang-query/tool/ClangQuery.cpp === --- c