[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

This revision was automatically updated to reflect the committed changes. Closed by commit rL342540: [clang-tidy] run-clang-tidy.py - fails using python 3.7 (authored by Abpostelnicu, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D512

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

Abpostelnicu updated this revision to Diff 166095. https://reviews.llvm.org/D51220 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py === --- clang-tidy/tool/run-clang-tidy.py +++ clang-tidy/tool/ru

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

JonasToth added a comment. Unicode works both with python3 and python2 (but seemed to work before too). Otherwise LG Comment at: clang-tidy/tool/run-clang-tidy.py:169 failed_files.append(name) - -if is_py2: The patch does not apply clean to master b

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

lebedev.ri added a comment. Have you seen https://reviews.llvm.org/D36624 / https://reviews.llvm.org/D38289 ? Please test how it behaves with both the python2 and python3 when the clang-tidy output contains non-ASCII symbols. https://reviews.llvm.org/D51220 _

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

JonasToth added a comment. LG from my side, but please let @aaron.ballman or @alexfh approve first Am 24.08.2018 um 18:08 schrieb Andi via Phabricator: > Abpostelnicu added a comment. > > I can confirm tested on: > 2.7.15 > 3.7.0 > > On both it worked. > > - https://reviews.llvm.org/F704765

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

Abpostelnicu added a comment. I can confirm tested on: 2.7.15 3.7.0 On both it worked. - F7047650: signature.asc https://reviews.llvm.org/D51220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

JonasToth added a comment. Could you please verify it is actually working? Am 24.08.2018 um 18:05 schrieb Andi via Phabricator: > Abpostelnicu added a comment. > > In https://reviews.llvm.org/D51220#1212463, @JonasToth wrote: > >> I don't know a lot about how to write portable code! >> >> But

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

Abpostelnicu added a comment. In https://reviews.llvm.org/D51220#1212463, @JonasToth wrote: > I don't know a lot about how to write portable code! > > But wouldn't this be out usecase? > http://python-future.org/compatible_idioms.html#file-io-with-open > Using the `decode` is supposed to work i

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

Abpostelnicu updated this revision to Diff 162391. https://reviews.llvm.org/D51220 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py === --- clang-tidy/tool/run-clang-tidy.py +++ clang-tidy/tool/ru

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

JonasToth added a comment. I don't know a lot about how to write portable code! But wouldn't this be out usecase? http://python-future.org/compatible_idioms.html#file-io-with-open Using the `decode` is supposed to work in both pythons Repository: rCTE Clang Tools Extra https://reviews.llvm.

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

JonasToth added a comment. Please create the patch with full context (https://www.llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51220 ___ cfe-commits mailin