This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341583: Fix reported range of partial token replacement
(authored by steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51192?vs=163447&id=164275#toc
Repository:
rCTE Clan
aaron.ballman added a comment.
In https://reviews.llvm.org/D51192#1226341, @steveire wrote:
> Thanks.
>
> The `arc` tool already inserted `Differential Revision:` into my git commit,
> but that's not what I wonder about. I'm looking for something I can insert
> into my git commit so that the bu
steveire added a comment.
Thanks.
The `arc` tool already inserted `Differential Revision:` into my git commit,
but that's not what I wonder about. I'm looking for something I can insert into
my git commit so that the bug will automatically be closed when I commit (and
so that the bug will get
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D51192#1226326, @steveire wrote:
> As far as I know, no existing clang-tidy checks are affected. I discovered
> this while implementing a custom check
steveire added a comment.
As far as I know, no existing clang-tidy checks are affected. I discovered this
while implementing a custom check. See
https://bugs.llvm.org/show_bug.cgi?id=38678
By the way, is there some keyword I should use in commit messages to link to
bugs properly?
Repository:
aaron.ballman added a comment.
In https://reviews.llvm.org/D51192#1226312, @steveire wrote:
> In https://reviews.llvm.org/D51192#1226282, @aaron.ballman wrote:
>
> > I'd probably pipe the diagnostic output to a temporary file that gets
> > FileChecked with strict whitespace to see if the underli
steveire added a comment.
In https://reviews.llvm.org/D51192#1226282, @aaron.ballman wrote:
> In https://reviews.llvm.org/D51192#1226257, @steveire wrote:
>
> > How? This is 'private' code. I don't think it's worth changing that or
> > creating a test with a huge amount of infrastructure in or
aaron.ballman added a comment.
In https://reviews.llvm.org/D51192#1226257, @steveire wrote:
> How? This is 'private' code. I don't think it's worth changing that or
> creating a test with a huge amount of infrastructure in order to test this
> indirectly.
This is changing the observable behav
steveire added a comment.
How? This is 'private' code. I don't think it's worth changing that or creating
a test with a huge amount of infrastructure in order to test this indirectly.
Am I missing something?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
_
aaron.ballman added a comment.
I think the fix generally looks good, but can you please add some test coverage
for the change?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
___
cfe-commits mailing list
cfe-commits@lists.llvm
steveire updated this revision to Diff 163447.
steveire added a comment.
Move comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
Files:
clang-tidy/ClangTidy.cpp
Index: clang-tidy/ClangTidy.cpp
===
---
steveire updated this revision to Diff 162288.
steveire added a comment.
Fix reported range of partial token replacement
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
Files:
clang-tidy/ClangTidy.cpp
Index: clang-tidy/ClangTidy.cpp
steveire created this revision.
steveire added reviewers: klimek, rsmith.
Herald added a subscriber: cfe-commits.
Fixes bug: 38678
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
Files:
clang-tidy/ClangTidy.cpp
Index: clang-tidy/ClangTidy.cpp
==
13 matches
Mail list logo
