This revision was automatically updated to reflect the committed changes.
Closed by commit rL340605: [clangd] Implement LIMIT iterator (authored by
omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51029?vs=162341&id=162359#toc
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/unittests/clangd/DexIndexTests.cpp:34
+consumeIDs(std::unique_ptr It,
+ size_t Limit = std::numeric_limits::max()) {
+ auto
kbobyrev updated this revision to Diff 162341.
kbobyrev marked 7 inline comments as done.
kbobyrev added a comment.
Address a round of comments & simplify code.
https://reviews.llvm.org/D51029
Files:
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra/clangd/index/dex/Iterator
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:109
+ float consume() override {
+if (reachedEnd())
return DEFAULT_BOOST_SCORE;
this isn't possible, as the item being consumed is the value of peek().
You co
kbobyrev updated this revision to Diff 162183.
kbobyrev marked 3 inline comments as done.
kbobyrev added a comment.
Address a round comments from Sam.
https://reviews.llvm.org/D51029
Files:
clang-tools-extra/clangd/index/dex/Iterator.cpp
clang-tools-extra/clangd/index/dex/Iterator.h
clang
sammccall added a comment.
first few comments, sorry I'll need to come back to this.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:90
virtual DocID peek() const = 0;
/// Retrieves boosting score. Query tree root should pass Root->peek() to
this
/// functio
kbobyrev updated this revision to Diff 161952.
kbobyrev added a comment.
Use better wording for internal `LimitIterator` documentation, perform minor
code cleanup.
https://reviews.llvm.org/D51029
Files:
clang-tools-extra/clangd/index/dex/Iterator.cpp
clang-tools-extra/clangd/index/dex/Iter
kbobyrev updated this revision to Diff 161947.
kbobyrev edited the summary of this revision.
kbobyrev added a reviewer: sammccall.
kbobyrev added a comment.
Rebase on top of BOOST iterator patch, update tests.
https://reviews.llvm.org/D51029
Files:
clang-tools-extra/clangd/index/dex/Iterator.
kbobyrev planned changes to this revision.
kbobyrev added a comment.
Since it's bundled with the BOOST iterator and doesn't make too much sense
without it, I should probable rebase on top of https://reviews.llvm.org/D50970
and add it as the parent revision.
https://reviews.llvm.org/D51029
_
kbobyrev updated this revision to Diff 161677.
kbobyrev added a comment.
Add comprehensive tests, improve documentation.
https://reviews.llvm.org/D51029
Files:
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra/clangd/index/dex/Iterator.cpp
clang-tools-extra/clangd/index/de
kbobyrev planned changes to this revision.
kbobyrev added a comment.
Patch is in the preview mode, I will add documentation and more tests before
opening a review.
https://reviews.llvm.org/D51029
___
cfe-commits mailing list
cfe-commits@lists.llvm.
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
https://reviews.llvm.org/D51029
Files:
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extr
12 matches
Mail list logo
