This revision was automatically updated to reflect the committed changes.
Closed by commit rL248318: [analyzer] Create one state for a range switch case
instead of multiple. (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D5102?vs=32664&id=35411#toc
Repository:
rL L
dcoughlin added a comment.
I will commit. Thanks!
http://reviews.llvm.org/D5102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ygribov added a subscriber: ygribov.
ygribov added a comment.
Folks, could someone commit this for us?
http://reviews.llvm.org/D5102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jordan_rose accepted this revision.
jordan_rose added a comment.
This revision is now accepted and ready to land.
Thanks for all the changes. This looks good to me! (And good catch for the
constant expression case.)
http://reviews.llvm.org/D5102
__
a.sidorin marked 8 inline comments as done.
a.sidorin added a comment.
http://reviews.llvm.org/D5102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin updated this revision to Diff 32664.
a.sidorin marked an inline comment as done.
a.sidorin added a comment.
Remove duplicating assertion.
http://reviews.llvm.org/D5102
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
include/clang/StaticAnalyzer/Core/Path
a.sidorin updated this revision to Diff 32293.
a.sidorin added a comment.
- Fix review notes
- Add some more tests
- Add a fix and a test for incorrect pruning of trivially unreachable case
statements in CFG for SwitchStmt (accidentially found while writing a test).
http://reviews.llvm.org/D510
a.sidorin added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp:215-220
@@ +214,8 @@
+ return assumeSymWithinInclusiveRange(State, Sym, From, To, InRange);
+return State;
+ } // end switch
+
+ case nonloc::ConcreteIntKind: {
+const l
a.sidorin added a comment.
Thank you for reply, Jordan.
> I guess the regular pings didn't work, so it was worth trying the gentle one?
> Sorry!
And it worked :)
I'll fix the issues you pointed.
http://reviews.llvm.org/D5102
___
cfe-commits mai
jordan_rose added a comment.
I guess the regular pings didn't work, so it was worth trying the gentle one?
Sorry!
This seems mostly ready to me, but I still have a few comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1646-1650
@@ -1644,2 +1645,7 @@
DefinedOrUnkn
a.sidorin added a comment.
Gentle ping.
http://reviews.llvm.org/D5102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
11 matches
Mail list logo
