hokein updated this revision to Diff 163284.
hokein marked 8 inline comments as done.
hokein added a comment.
- address review comments
- rescope the patch only focus on `findReferences` implementation.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50958
Files:
clangd/XRefs.
hokein added a comment.
Thanks for the comments.
In https://reviews.llvm.org/D50958#1212221, @sammccall wrote:
> I do have some questions there that would be good to discuss. Meanwhile,
> @hokein can you rebase this patch against head?
Yes, I'd love to, but since this patch is quite large, I
sammccall added a comment.
In https://reviews.llvm.org/D50958#1212179, @ilya-biryukov wrote:
> Parts of this patch were landed as https://reviews.llvm.org/D50847 and
> https://reviews.llvm.org/D50889, happy to discuss the design decisions
> ("merged" dynamic index, two callbacks), but that's pr
ilya-biryukov added a comment.
Parts of the patch contain were landed as https://reviews.llvm.org/D50847 and
https://reviews.llvm.org/D50889, happy to discuss the design decisions
("merged" dynamic index, two callbacks), but that's probably out of scope of
this patch.
Repository:
rCTE Clang
sammccall added a comment.
Mostly just reviewed the `references()` implementation.
For the infrastructure I have some high level questions:
- why are we combining SymbolSlab and occurrences?
- what's the motivation for the separate preamble/main-file indexes
- why put more functionality into Sym
hokein added a comment.
This patch is incomplete, and it is a **prototype** based on our discussion
last week. You can patch it locally, and play around with VSCode.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50958
___
cfe-comm
hokein updated this revision to Diff 161441.
hokein added a comment.
More cleanups.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50958
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/Protocol.cpp
clan
hokein created this revision.
hokein added reviewers: ilya-biryukov, ioeric.
Herald added subscribers: kadircet, arphaman, mgrang, jkorous, MaskRay,
javed.absar, mgorny.
Depends on the AST callback interfaces.
- https://reviews.llvm.org/D50847
- https://reviews.llvm.org/D50889
Repository:
rC
