[PATCH] D50947: lambdas in modules: make PendingFakeDefinitionData a set

2018-09-05 Thread Steve O'Brien via Phabricator via cfe-commits
elsteveogrande abandoned this revision. elsteveogrande added a comment. I'll drop this one, since this is not the logic change we want. Repository: rC Clang https://reviews.llvm.org/D50947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D50947: lambdas in modules: make PendingFakeDefinitionData a set

2018-09-05 Thread Steve O'Brien via Phabricator via cfe-commits
elsteveogrande abandoned this revision. elsteveogrande added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:1760-1765 - if (PFDI != Reader.PendingFakeDefinitionData.end() && - PFDI->second == ASTReader::PendingFakeDefinitionKind::Fake) { + if (PFDI != Rea

[PATCH] D50947: lambdas in modules: make PendingFakeDefinitionData a set

2018-09-05 Thread Steve O'Brien via Phabricator via cfe-commits
elsteveogrande added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:1766 + +// FIXME: handle serialized lambdas assert(!DD.IsLambda && !MergeDD.IsLambda && "faked up lambda definition?"); rsmith wrote: > Did you mean to add this FIXME?

[PATCH] D50947: lambdas in modules: make PendingFakeDefinitionData a set

2018-09-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:1766 + +// FIXME: handle serialized lambdas assert(!DD.IsLambda && !MergeDD.IsLambda && "faked up lambda definition?"); Did you mean to add this FIXME? Comme