[PATCH] D50945: [Lex] Make HeaderMaps a unique_ptr vector

This revision was automatically updated to reflect the committed changes. Closed by commit rC340198: [Lex] Make HeaderMaps a unique_ptr vector (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D50945?vs=161391&id=161530#toc Repository: rC Clang https://

[PATCH] D50945: [Lex] Make HeaderMaps a unique_ptr vector

MaskRay added a comment. Thanks! Repository: rC Clang https://reviews.llvm.org/D50945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50945: [Lex] Make HeaderMaps a unique_ptr vector

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rC Clang https://reviews.llvm.org/D50945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D50945: [Lex] Make HeaderMaps a unique_ptr vector

dblaikie added a comment. In https://reviews.llvm.org/D50945#1205337, @kristina wrote: > Given the context (class an file name itself) and documentation around the > function, I don't think in this particular case it improves readability or > maintainability, the lifetime of the `HeaderMap` is

[PATCH] D50945: [Lex] Make HeaderMaps a unique_ptr vector

kristina added a comment. Given the context (class an file name itself) and documentation around the function, I don't think in this particular case it improves readability or maintainability, the lifetime of the `HeaderMap` is (IMHO) fairly obvious from the const qualifier and from the documen

[PATCH] D50945: [Lex] Make HeaderMaps a unique_ptr vector

MaskRay created this revision. MaskRay added reviewers: Eugene.Zelenko, dblaikie. Herald added a subscriber: cfe-commits. unique_ptr makes the ownership clearer than a raw pointer container. Repository: rC Clang https://reviews.llvm.org/D50945 Files: include/clang/Lex/HeaderMap.h include