spatel added a subscriber: lei.
spatel added a comment.
And the 3rd time is the charm...
I have no explanation for why this works, but I removed the microsoft diffs,
and now gcc doesn't crash.
cc'ing @lei as owner of the bots that have this problem:
http://lab.llvm.org:8011/builders/clang-ppc64be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340141: [CodeGen] add rotate builtins that map to LLVM
funnel shift (authored by spatel, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50924?vs=161398&id=161402#toc
Repository:
spatel reopened this revision.
spatel added a comment.
This revision is now accepted and ready to land.
Reopening again because I reverted this again for the same reason at
https://reviews.llvm.org/rL340138.
Repository:
rL LLVM
https://reviews.llvm.org/D50924
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340137: [CodeGen] add/fix rotate builtins that map to LLVM
funnel shift (retry) (authored by spatel, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
spatel added a comment.
In https://reviews.llvm.org/D50924#1205310, @spatel wrote:
> Reopening because I reverted at https://reviews.llvm.org/rL340136. Not sure
> yet what is causing the problem on those bots.
The common trait for those failures appears to be that the host compiler is:
gcc ver
spatel reopened this revision.
spatel added a comment.
This revision is now accepted and ready to land.
Reopening because I reverted at https://reviews.llvm.org/rL340136. Not sure yet
what is causing the problem on those bots.
Repository:
rC Clang
https://reviews.llvm.org/D50924
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340135: [CodeGen] add rotate builtins (authored by spatel,
committed by ).
Herald added a subscriber: kristina.
Repository:
rC Clang
https://reviews.llvm.org/D50924
Files:
docs/LanguageExtensions.rs
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Thanks, looks good!
https://reviews.llvm.org/D50924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
lebedev.ri added a comment.
Looks ok to me.
https://reviews.llvm.org/D50924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spatel updated this revision to Diff 161346.
spatel added a comment.
Patch updated:
Update the existing Microsoft rotate builtins to also use the LLVM funnel shift
intrinsics.
https://reviews.llvm.org/D50924
Files:
docs/LanguageExtensions.rst
include/clang/Basic/Builtins.def
lib/CodeGen/
spatel added a comment.
In https://reviews.llvm.org/D50924#1204772, @rnk wrote:
> Do you mind updating the _rotl* and _rotr* intrinsics to use the same
> codegen? They're right above in the switch.
Sure - I didn't know about those.
https://reviews.llvm.org/D50924
_
spatel updated this revision to Diff 161325.
spatel added a comment.
Patch updated:
Fixed a docs typo.
https://reviews.llvm.org/D50924
Files:
docs/LanguageExtensions.rst
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtin-rotate.c
Index: test/CodeGen/builtin
rnk added a comment.
Do you mind updating the _rotl* and _rotr* intrinsics to use the same codegen?
They're right above in the switch.
https://reviews.llvm.org/D50924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
spatel created this revision.
spatel added reviewers: fabiang, craig.topper, rnk, thakis.
Herald added a subscriber: mcrosier.
This exposes the LLVM funnel shift intrinsics as more familiar bit rotation
functions in clang (when both halves of a funnel shift are the same value, it's
a rotate).
I
14 matches
Mail list logo
