lebedev.ri resigned from this revision.
lebedev.ri added a comment.
This revision now requires review to proceed.
Herald added subscribers: StephenFan, mgehre.
Herald added a reviewer: njames93.
Herald added a project: All.
This review seems to be stuck/dead, consider abandoning if no longer relev
lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.
Marking both of these as "changes requested" to highlight the similarity of
issues in them.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews
lebedev.ri added inline comments.
Comment at: clang-tidy/abseil/AutoMakeUniqueCheck.cpp:21
+void AutoMakeUniqueCheck::registerMatchers(MatchFinder* finder) {
+ if (!getLangOpts().CPlusPlus) return;
+
zinovy.nis wrote:
> JonasToth wrote:
> > Please clang-format,
zinovy.nis added inline comments.
Comment at: clang-tidy/abseil/AutoMakeUniqueCheck.cpp:21
+void AutoMakeUniqueCheck::registerMatchers(MatchFinder* finder) {
+ if (!getLangOpts().CPlusPlus) return;
+
JonasToth wrote:
> Please clang-format, `return` on next line.
zinovy.nis added a comment.
In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote:
> 1. Please always upload all patches with full context.
> 2. There already is `modernize-use-auto`. Does it handle this case? Then this
> should be just an alias to that check. Else, i think it would be b
JonasToth added inline comments.
Comment at: test/clang-tidy/abseil-auto-make-unique.cpp:73
+ // Different type. No change.
+ std::unique_ptr z = make_unique();
+ std::unique_ptr z2(make_unique());
JonasToth wrote:
> lets consider a 3 level class hierarchy.
>
JonasToth added inline comments.
Comment at: clang-tidy/abseil/AutoMakeUniqueCheck.cpp:21
+void AutoMakeUniqueCheck::registerMatchers(MatchFinder* finder) {
+ if (!getLangOpts().CPlusPlus) return;
+
Please clang-format, `return` on next line.
JonasToth added a comment.
In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote:
> 1. Please always upload all patches with full context.
> 2. There already is `modernize-use-auto`. Does it handle this case? Then this
> should be just an alias to that check. Else, i think it would be be
