ldionne commandeered this revision.
ldionne edited reviewers, added: mclow.lists; removed: ldionne.
ldionne added a comment.
This revision now requires review to proceed.
Herald added a subscriber: jkorous.
Commandeering to close as I don't think this applies anymore.
Repository:
rG LLVM Githu
ldionne added a reviewer: libc++.
ldionne added a comment.
Is this still relevant? We don't have `_LIBCPP_HAS_C11_FEATURES` anymore. If
not relevant, let's close this to clear up the queue.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50739/new/
https://reviews.llvm.org/D50739
__
ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
Marking as "request changes" to get off my review queue until the problem I
pointed w.r.t. `TEST_HAS_C11_FEATURES` and `_LIBCPP_HAS_C11_FEATURES` always
being undefined is resolved
ldionne added inline comments.
Comment at: include/__config:433
-#if __ISO_C_VISIBLE >= 2011 || __cplusplus >= 201103L
+#if __ISO_C_VISIBLE >= 2011
# if defined(__FreeBSD__)
ldionne wrote:
> mclow.lists wrote:
> > Should we be using `__ISO_C_VISIBLE` here, or
ldionne added inline comments.
Comment at: include/__config:433
-#if __ISO_C_VISIBLE >= 2011 || __cplusplus >= 201103L
+#if __ISO_C_VISIBLE >= 2011
# if defined(__FreeBSD__)
mclow.lists wrote:
> Should we be using `__ISO_C_VISIBLE` here, or `__STDC_VERSION__`
mclow.lists added inline comments.
Comment at: include/__config:433
-#if __ISO_C_VISIBLE >= 2011 || __cplusplus >= 201103L
+#if __ISO_C_VISIBLE >= 2011
# if defined(__FreeBSD__)
Should we be using `__ISO_C_VISIBLE` here, or `__STDC_VERSION__`?
I didn't change
mclow.lists created this revision.
mclow.lists added reviewers: ldionne, EricWF, dexonsmith.
During the review of https://reviews.llvm.org/D50719, I said:
> The presence/absence of C11 features in the underlying C library does not
> depend on what version of the C++ language we're compiling with
