This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE340001: [clangd] Always use the latest preamble (authored
by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50695?vs=160983&id=161177#toc
Repository:
rCTE Clang Tools Ex
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hokein updated this revision to Diff 160983.
hokein marked 4 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50695
Files:
clangd/TUScheduler.cpp
unittests/clangd/XRefsTests.cpp
Index: unittests/clang
ilya-biryukov added a comment.
Thanks, we were previously getting inconsistent ASTs (i.e. using different
preambles), depending on whether they were built in `TUScheduler::update` or in
`TUScheduler::runWithAST` handlers.
Just a few NITs.
Comment at: clangd/TUScheduler.cpp:37
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, javed.absar.
Fix an inconsistent behavior of using `LastBuiltPreamble`/`NewPreamble`
in TUScheduler (see the test for details), AST should always use
NewPreamble. Thi
