[PATCH] D50689: [clangd] NFC: Improve Dex Iterators debugging traits

2018-08-16 Thread Kirill Bobyrev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE339877: [clangd] NFC: Improve Dex Iterators debugging traits (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D50689?vs=161013&id=161014#toc Repository: rCTE

[PATCH] D50689: [clangd] NFC: Improve Dex Iterators debugging traits

2018-08-16 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 161013. kbobyrev marked an inline comment as done. kbobyrev added a comment. Improved wording to prevent confusion: no more `IDX` (which is the one pointed to by the iterator) and `IDN`; just mention that the element being pointed to is the one enclosed in

[PATCH] D50689: [clangd] NFC: Improve Dex Iterators debugging traits

2018-08-16 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:102 /// ChildN is N-th iterator child. Raw iterators over PostingList are - /// represented as "[ID1, ID2, .

[PATCH] D50689: [clangd] NFC: Improve Dex Iterators debugging traits

2018-08-14 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: arphaman, jkorous, MaskRay. https://reviews.llvm.org/D50689 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp clang-tools-extra/clangd/i