pirama abandoned this revision.
pirama added a comment.
Thanks for the clarification Richard and Eli. I agree that leaving the status
quo will match the intent of the macro. I'll abandon this.
Repository:
rC Clang
https://reviews.llvm.org/D50683
_
efriedma added a comment.
The C++ standard just says "An integer literal of type std::size_t whose value
is the alignment guaranteed by a call to operator new(std::size_t) or operator
new[](std::size_t)." I would take that in the obvious sense, that any pointer
returned by operator new must ha
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
This doesn't seem necessary. `NewAlign` specifies the alignment beyond which
types acquire "new-extended alignment" per the C++ standard, or equivalently
the alignment beyond which w
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Basic/TargetInfo.cpp:72
+// For 64-bit Android, alignment is 8 bytes for allocations <= 8 bytes.
+NewAlign = (Triple.isArch64Bit() || Triple.
pirama created this revision.
pirama added reviewers: rsmith, srhines.
Android uses jemalloc allocator, which returns 8-byte-aligned pointers for
allocations smaller than 8 bytes for 64-bit architectures. Set NewAlign
conservatively to 8 bytes.
Repository:
rC Clang
https://reviews.llvm.org/D
