[PATCH] D50666: Fix Stmt::ignoreImplicit

2018-08-14 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL339730: Fix Stmt::ignoreImplicit (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50666 Files: cfe/trunk/lib/AST/Stmt.cpp

[PATCH] D50666: Fix Stmt::ignoreImplicit

2018-08-13 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/AST/Stmt.cpp:121-122 - if (auto *bte = dyn_cast(s)) -s = bte->getSubExpr(); +if (auto *ewc = dyn_cast(s)) + s = ewc->getSubExpr(); -

[PATCH] D50666: Fix Stmt::ignoreImplicit

2018-08-13 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added reviewers: rsmith, dblaikie, klimek. Herald added a subscriber: cfe-commits. A CXXBindTemporaryExpr can appear inside an ImplicitCastExpr, and was not ignored previously. Fixes the case reported in PR37327. Repository: rC Clang https://reviews.l