Hi Ilya,
This commit broke some of ARM's bots, log are available here:
http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/3120/steps/ninja%20check%201/logs/stdio
Thanks
Yvan
On Tue, 14 Aug 2018 at 11:37, Phabricator via Phabricator via
cfe-commits wrote:
>
> This revision was aut
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339665: [clangd] Show non-instantiated decls in
signatureHelp (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50645
Files
ilya-biryukov updated this revision to Diff 160536.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Use 'auto*' instead of 'auto'
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50645
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeComple
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:721
+ // would get 'std::basic_string').
+ if (auto Func = Candidate.getFunction()) {
+if (auto Pattern = Func->getTemplateInstantiationPattern())
hokein wrote:
> nit: auto
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good.
Comment at: clangd/CodeComplete.cpp:721
+ // would get 'std::basic_string').
+ if (auto Func = Candidate.getFunction()) {
+if (auto Pattern = Fu
ilya-biryukov created this revision.
ilya-biryukov added reviewers: hokein, ioeric, kadircet.
Herald added subscribers: arphaman, jkorous, MaskRay.
To avoid producing very verbose output in substitutions involving
typedefs, e.g.
T -> std::vector::iterator
gets turned into an unreadable mess wh
