[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

This revision was automatically updated to reflect the committed changes. Closed by commit rC340471: [Driver] Check normalized triples for multiarch runtime path (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D50547?vs=161821&id=162090#toc Repository:

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

beanz accepted this revision. beanz added a comment. LGTM as-is Comment at: clang/lib/Driver/ToolChain.cpp:372 - const Driver &D = getDriver(); - SmallString<128> P(D.ResourceDir); - llvm::sys::path::append(P, D.getTargetTriple(), "lib"); - if (getVFS().exists(P)) { + fo

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:372 - const Driver &D = getDriver(); - SmallString<128> P(D.ResourceDir); - llvm::sys::path::append(P, D.getTargetTriple(), "lib"); - if (getVFS().exists(P)) { + for (const auto &LibPath : getLibraryP

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek updated this revision to Diff 161821. Herald added a reviewer: javed.absar. Repository: rC Clang https://reviews.llvm.org/D50547 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/aarch64-fuchs

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek added a comment. I also need to create the following empty files for tests to pass (somehow those are not displayed by Phabricator): clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/aarch64-fuchsia/lib/libclang_rt.asan-preinit.a clang/test/Driver/Inputs/resource_dir_with

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek updated this revision to Diff 161818. Repository: rC Clang https://reviews.llvm.org/D50547 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp Index: clang/lib/Driver/ToolChain.cpp === --- cla

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

beanz added a comment. Just want to bring an IRC conversation that I had with @phosek into the proper code review. This patch is great as-is, but if we want to extend this to Darwin there are some problems because of how Darwin handles triples. Specifically Darwin has multiple potentially vali

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D50547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek added a comment. In https://reviews.llvm.org/D50547#1198218, @rnk wrote: > Would it be to much to check both the normalized and non-normalized? Done, currently I'm only checking the provided target triple followed by the normalized one, I'm not checking the effective triple but it'd be

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek updated this revision to Diff 161031. Repository: rC Clang https://reviews.llvm.org/D50547 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp Index: clang/lib/Driver/ToolChain.cpp === --- cla

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

rnk added a comment. Would it be to much to check both the normalized and non-normalized? Repository: rC Clang https://reviews.llvm.org/D50547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek created this revision. phosek added reviewers: rnk, echristo, chandlerc, beanz. Herald added subscribers: cfe-commits, JDevlieghere, mgorny. Previously we used target triple as provided which matches the GCC behavior, but it also means that all clients have to be consistent in their spellin