riccibruno added a comment.
Some inline comments. Since you already committed it I don't think it
is worth bothering with them.
Comment at: cfe/trunk/include/clang/Sema/ParsedAttr.h:124
+ detail::TypeTagForDatatypeData, ParsedType, detail::PropertyData>;
+
+ size_t numTra
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339380: [NFC] Convert ParsedAttr to use
llvm::TrailingObjects (authored by erichkeane, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50531?v
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks good, thanks. (I'm not sure why `PropertyData` needs special handling
rather than being treated as two `IdentifierLoc` arguments, but that's not made
any worse here, just perhaps a bit m
erichkeane added inline comments.
Comment at: include/clang/Sema/ParsedAttr.h:80
+struct TypeTagForDatatypeData {
+ ParsedType *MatchingCType;
Because all of these became part of the TYPE of ParsedAttr now, they need to be
defined outside of ParsedAttr. Addi
erichkeane created this revision.
erichkeane added reviewers: rjmccall, riccibruno, aaron.ballman.
ParsedAttr is using a hand-rolled trailing-objects
implementation that gets cleaned up quite a bit by
just using llvm::TrailingObjects. This is a large
TrailingObjects list, but most things are leng
