[PATCH] D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest"

2019-04-30 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. I think I figured it out. r359604 should fix the bug that caused this to be reverted twice. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50515/new/ https://reviews.llvm.org/D50515 ___ cfe-com

[PATCH] D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest"

2019-04-30 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. vitalybuka told me that this should repro things locally: mkdir /tmp/bot cd /tmp/bot svn checkout https://llvm.org/svn/llvm-project/zorg BUILDBOT_CLOBBER= BUILDBOT_REVISION=YOUR_REV zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_fast.sh 2>&1 | tee buildlog

[PATCH] D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest"

2019-04-30 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Herald added a project: LLVM. I re-landed this to get access to the msan output, since the link above has long expired. Here's the new link: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/31821/steps/check-clang%20msan/logs/stdio Sadly, the bot outp

[PATCH] D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest"

2018-09-03 Thread Brian Gesiak via Phabricator via cfe-commits
modocache added a comment. Excellent, I think pushing this along with https://reviews.llvm.org/D50410 revealed the true error, as an MSAN buildbot tells use there's a use of an uninitialized value: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/23176/steps/check-clang%20ms

[PATCH] D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest"

2018-09-03 Thread Brian Gesiak via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341329: Re-push "[Option] Fix PR37006 prefix choice in findNearest" (authored by modocache, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50

[PATCH] D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest"

2018-09-03 Thread Brian Gesiak via Phabricator via cfe-commits
modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Thanks! I'll land https://reviews.llvm.org/D50410, then this, and monitor the buildbots to see what happens. If they fail again I may revert this once again. Thanks again for looking int

[PATCH] D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest"

2018-08-09 Thread Arnaud Coomans via Phabricator via cfe-commits
acoomans created this revision. acoomans added a reviewer: cfe-commits. Original changeset (https://reviews.llvm.org/D46776) by @modocache. It was reverted after the PS4 bot failed. The issue has been determined to be with the way the PS4 SDK handles this particular option. https://reviews.llvm