This revision was automatically updated to reflect the committed changes.
Closed by commit rL339420: clang-cl: Support /guard:cf,nochecks (authored by
hans, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50513?vs=159927&id=160076#toc
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm!
There is some additional work to do to put .gfids$y sections into appropriate
comdat sections, but that's future work.
https://reviews.llvm.org/D50513
hans added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:463
// We want function ID tables for Control Flow Guard.
-getModule().addModuleFlag(llvm::Module::Warning, "cfguard", 1);
+getModule().addModuleFlag(llvm::Module::Warning, "cfguardtable", 1);
}
hans created this revision.
hans added reviewers: rnk, thakis.
This extension emits the guard cf table without inserting the instrumentation.
Currently that's what clang-cl does with /guard:cf anyway, but this allows a
user to request that explicitly.
https://reviews.llvm.org/D50513
Files:
