This revision was automatically updated to reflect the committed changes.
Closed by commit rL339540: [clang] Store code completion token range in
preprocessor. (authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50443
F
kadircet updated this revision to Diff 160299.
kadircet added a comment.
- Resolve discussions.
- Fix typo.
Repository:
rC Clang
https://reviews.llvm.org/D50443
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/Preprocessor.cpp
Index: lib/Lex/Preprocessor.cpp
ilya-biryukov added a comment.
NIT: maybe also note the number of the clangd revision in this change's
description
Repository:
rC Clang
https://reviews.llvm.org/D50443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM, but let's land together with a dependent revision to hove some code that
actually tests it.
Comment at: include/clang/Lex/Preprocessor.h:313
+ /// Ran
kadircet updated this revision to Diff 159703.
kadircet marked an inline comment as done.
kadircet added a comment.
- Resolve discussions.
Repository:
rC Clang
https://reviews.llvm.org/D50443
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/Preprocessor.cpp
Index: lib/Lex/Preprocessor.c
