This revision was automatically updated to reflect the committed changes.
Closed by commit rL341463: [clangd] Sort GoToDefinition results. (authored by
hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50438
Files:
clang-tools-ext
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341463: [clangd] Sort GoToDefinition results. (authored by
hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50438?vs=164014&id=164017#toc
Repository:
rL LLVM
https://revi
hokein updated this revision to Diff 164014.
hokein added a comment.
Fix code style.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50438
Files:
clangd/XRefs.cpp
unittests/clangd/XRefsTests.cpp
Index: unittests/clangd/XRefsTests.cpp
hokein updated this revision to Diff 164013.
hokein added a comment.
Rebase to master.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50438
Files:
clangd/XRefs.cpp
unittests/clangd/XRefsTests.cpp
Index: unittests/clangd/XRefsTests.cpp
==
ilya-biryukov added a comment.
In https://reviews.llvm.org/D50438#1224289, @hokein wrote:>
> Thanks, and sorry for the delay here, I was planning to submit it after
> https://reviews.llvm.org/D50958 is submitted (probably today?)-- because it
> requires some rebasing changes.
Thanks for the u
hokein added a comment.
In https://reviews.llvm.org/D50438#1224287, @ilya-biryukov wrote:
> @hokein, would it be fine if I submit this change for you?
> It would be nice to get this fix in before you get back from vacation.
Thanks, and sorry for the delay here, I was planning to submit it afte
ilya-biryukov added a comment.
@hokein, would it be fine if I submit this change for you?
It would be nice to get this fix in before you get back from vacation.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50438
___
cfe-commits ma
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LG, thanks.
And a question of what are the things we can accidentally misdetect as explicit
Comment at: clangd/XRefs.cpp:105
+// Sort results. Declarations
hokein updated this revision to Diff 163311.
hokein marked 3 inline comments as done.
hokein added a comment.
Address review comments, return deterministic results.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50438
Files:
clangd/XRefs.cpp
unittests/clangd/XRefsTests.cpp
hokein added a comment.
Sorry, I just realized I didn't reply the comments in the first review (they
were in my draft).
Comment at: clangd/XRefs.cpp:71
+struct DeclInfo {
+ const Decl *D;
ilya-biryukov wrote:
> NIT: maybe call `Occurence` instead? As this i
ilya-biryukov added a comment.
Sorry for the delays with this review
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ilya-biryukov added inline comments.
Herald added a subscriber: kadircet.
Comment at: clangd/XRefs.cpp:105
+// Sort results. Declarations being referenced explicitly come first.
+std::sort(Result.begin(), Result.end(),
+ [](const DeclInfo &L, const DeclInfo &
hokein updated this revision to Diff 160544.
hokein marked 3 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50438
Files:
clangd/XRefs.cpp
unittests/clangd/XRefsTests.cpp
Index: unittests/clangd/XRefs
ilya-biryukov added inline comments.
Comment at: clangd/XRefs.cpp:71
+struct DeclInfo {
+ const Decl *D;
NIT: maybe call `Occurence` instead? As this is actually a `Decl` with some
extra data, computed based on the expression it originated from. Occurence
se
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: arphaman, mgrang, jkorous, MaskRay, ioeric.
GoToDefinition returns all declaration results (implicit/explicit) that are
in the same location, and the results are returned in arbitrary order.
Some LSP c
15 matches
Mail list logo
