owenpan abandoned this revision.
owenpan added a comment.
We habe `AlignCompound` now.
Herald added a comment.
NOTE: Clang-Format Team Automated Review Comment
Your review contains a change to clang/include/clang/Format/Format.h but does
not contain an update to ClangFormatStyleOptions.rst
C
rolandschulz added a comment.
Is anyone still working on this or is a new author needed?
For what's it worth it, I'm in favor of the first version (right hand aligned)
for different sized operators.
A matching bug exists at: https://bugs.llvm.org/show_bug.cgi?id=31681
Repository:
rC Clang
krasimir added inline comments.
Comment at: include/clang/Format/Format.h:85
+ /// matching assignment operators. This includes consecutive |=, +=
+ /// -=, /=, *=. This will result in formattings like
/// \code
Please add tests for these. Also it's not clea
owenpan requested changes to this revision.
owenpan added inline comments.
This revision now requires changes to proceed.
Comment at: include/clang/Format/Format.h:91-93
+ /// int ddd += 12;
+ /// int ee += 22;
+ /// int f += 23;
These are invalid C++
kristina added subscribers: djasper, klimek, kristina.
kristina added a comment.
Please upload your diffs with full context (use `-U9` when doing the diff)
and update them. I don't think there is a code owner for this part but @klimek
and @djasper do most reviews to do with clang-format, so
PDoakORNL added a comment.
So it's been a week, is there an owner for clang/lib/Format?
Repository:
rC Clang
https://reviews.llvm.org/D50403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
