erichkeane abandoned this revision.
erichkeane added a comment.
After talking to Aaron, we're going to try to use the lexical names for ALL
cases. This requires a bunch of of accessory work (in order to get the
Identifier from the SourceRange), so it'll be split up into a couple of commits
and
erichkeane added inline comments.
Comment at: include/clang/Sema/ParsedAttr.h:956
+
+inline const DiagnosticBuilder &operator<<(const DiagnosticBuilder &DB,
+ const ParsedAttr *At) {
Note that the pointer-overload is requ
erichkeane created this revision.
erichkeane added reviewers: aaron.ballman, rjmccall.
The recent patch that reordered parsed attributes made it clear
that the diagnostics when printing attributes were incredibly
inconsistent. in the mutual-exclusion case, the order of the
attributes would chang