[PATCH] D50389: [clang-tidy] new check for Abseil

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:50 + *result.SourceManager, result.Context->getLangOpts()), + ")"); +} deannagarcia wrote: > JonasToth wrote: > > This line looks odd, does it com

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia added inline comments. Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:50 + *result.SourceManager, result.Context->getLangOpts()), + ")"); +} JonasToth wrote: > This line looks odd, does it come from clang-format?

[PATCH] D50389: [clang-tidy] new check for Abseil

JonasToth added a comment. LGTM with only the formatting question. But don't commit before any of the reviewers accepts (@alexfh @aaron.ballman usually have the last word) Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:50 + *result.SourceManager, resu

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 160109. deannagarcia marked 3 inline comments as done. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCh

[PATCH] D50389: [clang-tidy] new check for Abseil

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:29 + hasSourceExpression(ignoringParenCasts(cxxOperatorCallExpr( + hasOverloadedOperatorName("/"), argumentCountIs(2), + hasArgument(0, expr(IsDuration)), -

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 160096. deannagarcia marked 7 inline comments as done. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCh

[PATCH] D50389: [clang-tidy] new check for Abseil

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:32 + hasImplicitDestinationType(qualType(unless(isInteger(, + unless(hasParent(cxxStaticCastExpr(, + this); deannagarcia wrote: > JonasToth wro

[PATCH] D50389: [clang-tidy] new check for Abseil

alexfh added inline comments. Comment at: docs/clang-tidy/checks/abseil-duration-division.rst:8 +division of two ``absl::Duration`` objects returns an ``int64`` with any fractional +component truncated toward 0. See `this link

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia marked 9 inline comments as done. deannagarcia added inline comments. Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:32 + hasImplicitDestinationType(qualType(unless(isInteger(, + unless(hasParent(cxxStaticCastExpr(, + this); --

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 160013. Herald added a subscriber: mgorny. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs

[PATCH] D50389: [clang-tidy] new check for Abseil

hokein added a comment. Thanks for contributing to clang-tidy! Comment at: docs/clang-tidy/checks/abseil-duration-division.rst:3 + +abseil-duration-division + This is a nice document. Does abseil have similar thing in its official gui

[PATCH] D50389: [clang-tidy] new check for Abseil

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:37 +void DurationDivisionCheck::check(const MatchFinder::MatchResult& result) { + const auto* op = result.Nodes.getNodeAs("op"); + diag(op->getOperatorLoc(), JonasToth wrot

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 159590. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/ReleaseNotes.rst docs/clang-tidy/checks/abseil-duration-division.rs

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 159550. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/ReleaseNotes.rst docs/clang-tidy/checks/abseil-duration-division.rs

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 159537. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/clang-tidy/checks/abseil-duration-division.rst docs/clang-tidy/chec