[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

hokein added a comment. In https://reviews.llvm.org/D50389#1204514, @Eugene.Zelenko wrote: > Somehow documentation file was not committed. Oops, I forgot to `git add` to the doc file. `arc patch` somehow failed to apply this patch, I applied it manually. Added in https://reviews.llvm.org/rL34

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

Eugene.Zelenko added a comment. Somehow documentation file was not committed. https://reviews.llvm.org/D50389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

hokein closed this revision. hokein added a comment. Committed in https://reviews.llvm.org/rL340038. https://reviews.llvm.org/D50389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good from my side. I will commit for you if other reviewers have no further comments. https://reviews.llvm.org/D50389 ___ cfe-comm

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

deannagarcia added inline comments. Comment at: test/clang-tidy/abseil-duration-division.cpp:58 + // CHECK-MESSAGES: [[@LINE-4]]:45: warning: operator/ on absl::Duration objects + // CHECK-FIXES: double DoubleDivision(T t1, T t2) {return + // absl::FDivDuration(t1, t2);}

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

deannagarcia updated this revision to Diff 160582. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/ReleaseNotes.rst docs/clang-tidy

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

hokein added a comment. Looks mostly good. Comment at: test/clang-tidy/abseil-duration-division.cpp:58 + // CHECK-MESSAGES: [[@LINE-4]]:45: warning: operator/ on absl::Duration objects + // CHECK-FIXES: double DoubleDivision(T t1, T t2) {return + // absl::FDivDuration(t1, t

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

deannagarcia updated this revision to Diff 160338. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/ReleaseNotes.rst docs/clang-tidy

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

deannagarcia updated this revision to Diff 160336. deannagarcia marked 6 inline comments as done. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCh

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

deannagarcia added inline comments. Comment at: test/clang-tidy/abseil-duration-division.cpp:58 + // CHECK-MESSAGES: [[@LINE-4]]:45: warning: operator/ on absl::Duration objects + // CHECK-FIXES: double DoubleDivision(T t1, T t2) {return + // absl::FDivDuration(t1, t2);}

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

hokein added inline comments. Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:24 + + const auto IsDuration = + expr(hasType(cxxRecordDecl(hasName("::absl::Duration"; maybe call it `DurationExpr` since you have declared the variable as `expr(...