This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339384: Port getStartLoc -> getBeginLoc (authored by
steveire, committed by ).
Changed prior to commit:
https://reviews
steveire accepted this revision.
steveire added a comment.
Accepted as part of a whole-branch review here:
http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html
Repository:
rC Clang
https://reviews.llvm.org/D50349
___
steveire added a comment.
Thanks Hans. Yes, I made these patches with some simple sed oneliners.
Once these are approved in principle, I'll re-generate them before pushing.
I have also run clang-format on them, but didn't update Phab with the results
to reduce noise.
Repository:
rC Clang
h
hans added a comment.
In https://reviews.llvm.org/D50349#1190029, @rsmith wrote:
> +Hans (release manager for LLVM 7)
>
> Hans, this patch series will affect the API of common Clang classes,
> resulting in patches to Clang SVN needing some (mechanical) modifications to
> be applied to the Clang
rsmith added a comment.
+Hans (release manager for LLVM 7)
Hans, this patch series will affect the API of common Clang classes, resulting
in patches to Clang SVN needing some (mechanical) modifications to be applied
to the Clang 7 release branch if we land it now. What do you think about that?
steveire created this revision.
Herald added a reviewer: teemperor.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50349
Files:
include/clang/AST/Decl.h
lib/AST/ASTImporter.cpp
lib/Analysis/CloneDetection.cpp
lib/CodeGen/CoverageMappingGen.cpp
