[PATCH] D50341: [libcxx] Mark aligned allocation tests as XFAIL on old OSX versions

2018-08-13 Thread Louis Dionne via Phabricator via cfe-commits
ldionne updated this revision to Diff 160440. ldionne added a comment. Rewrite all XFAILs in light of issues brought up by Marshall. Repository: rCXX libc++ https://reviews.llvm.org/D50341 Files: libcxx/test/libcxx/memory/aligned_allocation_macro.pass.cpp libcxx/test/std/language.suppor

[PATCH] D50341: [libcxx] Mark aligned allocation tests as XFAIL on old OSX versions

2018-08-10 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. I still think we should go forward with this change since the tests _are_ expected to fail on the provided OS X versions, which do not contain the required operators. Repository: rCXX libc++ https://reviews.llvm.org/D50341

[PATCH] D50341: [libcxx] Mark aligned allocation tests as XFAIL on old OSX versions

2018-08-09 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added inline comments. Comment at: libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align.fail.cpp:15 // UNSUPPORTED: c++98, c++03, c++11, c++14, c++17 // UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, clang-

[PATCH] D50341: [libcxx] Mark aligned allocation tests as XFAIL on old OSX versions

2018-08-07 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added inline comments. Comment at: libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align.fail.cpp:15 // UNSUPPORTED: c++98, c++03, c++11, c++14, c++17 // UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, clang-

[PATCH] D50341: [libcxx] Mark aligned allocation tests as XFAIL on old OSX versions

2018-08-06 Thread Louis Dionne via Phabricator via cfe-commits
ldionne created this revision. ldionne added a reviewer: vsapsai. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, dexonsmith, christof. Since r338934, Clang emits an error when aligned allocation functions are used in conjunction with a system libc++ dylib that does not sup