This revision was automatically updated to reflect the committed changes.
Closed by commit rC346633: Support Swift in platform availability attribute
(authored by mwu, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D50318
Files:
include/clang/Basic/Attr.td
include/clang/Bas
michaelwu updated this revision to Diff 173607.
michaelwu added a comment.
Thanks for the review! All requested changes have been made, and I also had to
fix a test due to https://reviews.llvm.org/D50214
https://reviews.llvm.org/D50318
Files:
include/clang/Basic/Attr.td
include/clang/Basic
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a few small nits.
Comment at: lib/Parse/ParseDecl.cpp:1005
+if (Keyword == Ident_deprecated && Platform->Ident &&
+Platform->Ident->
jrmuizel added a comment.
Review ping
Repository:
rC Clang
https://reviews.llvm.org/D50318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jrmuizel added a comment.
Review ping
Repository:
rC Clang
https://reviews.llvm.org/D50318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
michaelwu added a comment.
Review ping
Repository:
rC Clang
https://reviews.llvm.org/D50318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
michaelwu created this revision.
michaelwu added reviewers: manmanren, friss, doug.gregor.
This adds support for Swift platform availability attributes. It's largely a
port of the changes made to https://github.com/apple/swift-clang/ for Swift
availability attributes. Specifically,
https://gith