This revision was automatically updated to reflect the committed changes.
Closed by commit rL339265: [DebugInfo][OpenCL] Address post-commit review for
r338299 (authored by scott.linder, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D50099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
scott.linder updated this revision to Diff 159512.
scott.linder added a comment.
Address feedback
https://reviews.llvm.org/D50099
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGenOpenCL/blocks.cl
Index: test/CodeGenOpenCL/blocks.cl
scott.linder added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:997
llvm::DINode::DIFlags Flags = llvm::DINode::FlagAppleBlock;
unsigned LineNo = 0;
echristo wrote:
> scott.linder wrote:
> > echristo wrote:
> > > Just noticed that LineNo is 0.
echristo added a comment.
In https://reviews.llvm.org/D50099#1189667, @scott.linder wrote:
> When I went to mark these as static I noticed they use
> `CGDebugInfo::CreateMemberType` which uses a couple other non-static member
> functions, and it starts to become difficult to tease things out in
scott.linder added a comment.
When I went to mark these as static I noticed they use
`CGDebugInfo::CreateMemberType` which uses a couple other non-static member
functions, and it starts to become difficult to tease things out into nice
clean static functions.
Comment at: lib
echristo added a comment.
Looks pretty good. Could you pass CGM in and just make the functions static I
couldn't see any other class variables, but might have missed something. One
inline comment as well.
-eric
Comment at: lib/CodeGen/CGDebugInfo.cpp:997
llvm::DINode::DIF
scott.linder updated this revision to Diff 158532.
scott.linder added a comment.
Add comments to explain OpenCL case
https://reviews.llvm.org/D50099
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGenOpenCL/blocks.cl
Index: test/CodeGenOpenCL/blocks.cl
=
scott.linder created this revision.
scott.linder added reviewers: echristo, Anastasia, yaxunl.
Herald added subscribers: cfe-commits, JDevlieghere, aprantl.
Refactor collection of member debug info into helper functions and add separate
debug-info tests.
The reason for `-debug-info-kind=limited`
