aaron.ballman closed this revision.
aaron.ballman marked 2 inline comments as done.
aaron.ballman added a comment.
Thank you for the review and discussion -- I've commit in r339455.
https://reviews.llvm.org/D50055
___
cfe-commits mailing list
cfe-co
Meinersbur added inline comments.
Comment at: docs/CodingStandards.rst:514-516
+line of code. Some common editors will automatically remove trailing whitespace
+when saving a file which causes unrelated changes to appear in diffs and
+commits.
JDevlieghere wrote:
JDevlieghere added inline comments.
Comment at: docs/CodingStandards.rst:514-516
+line of code. Some common editors will automatically remove trailing whitespace
+when saving a file which causes unrelated changes to appear in diffs and
+commits.
chandlerc wrote:
rnk added a comment.
In https://reviews.llvm.org/D50055#1188479, @chandlerc wrote:
> Maybe double check with Reid and/or Hal to make sure we've all ended up on
> the same page before landing though.
lgtm, thanks
https://reviews.llvm.org/D50055
_
chandlerc added inline comments.
Comment at: docs/CodingStandards.rst:514-516
+line of code. Some common editors will automatically remove trailing whitespace
+when saving a file which causes unrelated changes to appear in diffs and
+commits.
Meinersbur wrote:
>
Meinersbur added inline comments.
Comment at: docs/CodingStandards.rst:514-516
+line of code. Some common editors will automatically remove trailing whitespace
+when saving a file which causes unrelated changes to appear in diffs and
+commits.
Just to note that t
chandlerc accepted this revision.
chandlerc added a comment.
This looks really good to me and seems like a nice clarification of historical
practice. =D Thanks so much for driving an actual documentation update for
folks that simply would never know about these practices otherwise, I think it
w
aaron.ballman marked 2 inline comments as done.
aaron.ballman added inline comments.
Comment at: docs/CodingStandards.rst:512
+Do not commit changes that include trailing whitespace. Some common editors
will
+automatically remove trailing whitespace when saving a file which ca
aaron.ballman updated this revision to Diff 158731.
aaron.ballman added a comment.
Updating based on review feedback.
https://reviews.llvm.org/D50055
Files:
docs/CodingStandards.rst
docs/DeveloperPolicy.rst
docs/Lexicon.rst
Index: docs/Lexicon.rst
===
chandlerc added inline comments.
Comment at: docs/DeveloperPolicy.rst:395-408
+Commits with No Functional Change
+-
+
+It may be permissible to commit changes without prior review when the changes
+have no semantic impact on the code if the changes
hubert.reinterpretcast added inline comments.
Comment at: docs/DeveloperPolicy.rst:395-408
+Commits with No Functional Change
+-
+
+It may be permissible to commit changes without prior review when the changes
+have no semantic impact on the code i
hfinkel added inline comments.
Comment at: docs/CodingStandards.rst:512
+Do not commit changes that include trailing whitespace. Some common editors
will
+automatically remove trailing whitespace when saving a file which causes
This statement is confusing (mos
aaron.ballman added inline comments.
Comment at: docs/DeveloperPolicy.rst:395-408
+Commits with No Functional Change
+-
+
+It may be permissible to commit changes without prior review when the changes
+have no semantic impact on the code if the cha
chandlerc added inline comments.
Comment at: docs/DeveloperPolicy.rst:395-408
+Commits with No Functional Change
+-
+
+It may be permissible to commit changes without prior review when the changes
+have no semantic impact on the code if the changes
aaron.ballman added subscribers: llvm-commits, cfe-commits.
aaron.ballman added a comment.
In https://reviews.llvm.org/D50055#1183277, @probinson wrote:
> I think you forgot to subscribe llvm-commits to this review?
Oh shoot, good catch! I've added llvm-commits and cfe-commits both. Thank you
15 matches
Mail list logo
