[PATCH] D49997: [libcxx] Fix _LIBCPP_NO_EXCEPTIONS redefined warning

2018-08-01 Thread Louis Dionne via Phabricator via cfe-commits
ldionne closed this revision. ldionne added a comment. Committed as r32f108a0736 Repository: rCXX libc++ https://reviews.llvm.org/D49997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D49997: [libcxx] Fix _LIBCPP_NO_EXCEPTIONS redefined warning

2018-08-01 Thread Jason Lovett via Phabricator via cfe-commits
jasonl220 added a comment. Can you commit this for me, I don't have access. Thanks Repository: rCXX libc++ https://reviews.llvm.org/D49997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D49997: [libcxx] Fix _LIBCPP_NO_EXCEPTIONS redefined warning

2018-07-31 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I'm fine with this; it matches the pattern used on line #354 of this file. (which is in the 'clang' block). We don't do anything like this for the IBM or MS compilers - yet. Reposi

[PATCH] D49997: [libcxx] Fix _LIBCPP_NO_EXCEPTIONS redefined warning

2018-07-30 Thread Jason Lovett via Phabricator via cfe-commits
jasonl220 created this revision. jasonl220 added a reviewer: mclow.lists. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, ldionne. Fix GCC 7.2.0 redefinition warning when LIBCXX_ENABLE_EXCEPTIONS cmake option is not set. > llvm/projects/libcxx/include/__config:514:0: warn