[PATCH] D49945: [Fixed Point Arithmetic] Fix for FixedPointValueToString

This revision was automatically updated to reflect the committed changes. leonardchan marked an inline comment as done. Closed by commit rC339026: [Fixed Point Arithmetic] Fix for FixedPointValueToString (authored by leonardchan, committed by ). Repository: rC Clang https://reviews.llvm.org/D4

[PATCH] D49945: [Fixed Point Arithmetic] Fix for FixedPointValueToString

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: lib/AST/Expr.cpp:788 FixedPointValueToString( - S, llvm::APSInt::getUnsigned(getValue().getZExtValue()), Scale, Radix); + S, llvm::APSInt::getUnsigned(getValue().getZExtValue

[PATCH] D49945: [Fixed Point Arithmetic] Fix for FixedPointValueToString

ebevhan added inline comments. Comment at: lib/AST/Expr.cpp:788 FixedPointValueToString( - S, llvm::APSInt::getUnsigned(getValue().getZExtValue()), Scale, Radix); + S, llvm::APSInt::getUnsigned(getValue().getZExtValue()), Scale); return S.str(); U

[PATCH] D49945: [Fixed Point Arithmetic] Fix for FixedPointValueToString

ebevhan accepted this revision. ebevhan added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D49945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D49945: [Fixed Point Arithmetic] Fix for FixedPointValueToString

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, jakehehrlich, ebevhan, rjmccall. leonardchan added a project: clang. Herald added a subscriber: mgorny. - Print negative numbers correctly - Handle APInts of different sizes - Add formal unit tests for FixedPointValu