This revision was automatically updated to reflect the committed changes.
Closed by commit rC339569: Summary:Add clang::reinitializes attribute (authored
by mboehme, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49911?vs=160348&id=160351#toc
Repository:
rC Clang
https:/
mboehme updated this revision to Diff 160348.
mboehme marked 2 inline comments as done.
mboehme added a comment.
Rebase to head.
Repository:
rC Clang
https://reviews.llvm.org/D49911
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/Sema/SemaDeclAttr.cpp
test/Sema
mboehme marked 2 inline comments as done.
mboehme added a comment.
Thanks for the review!
In https://reviews.llvm.org/D49911#1186185, @aaron.ballman wrote:
> The attribute itself is looking reasonable aside from some minor nits, but
> this should not be committed until the clang-tidy functional
mboehme updated this revision to Diff 159007.
mboehme marked an inline comment as done.
mboehme added a comment.
Various changes in response to review comments.
Repository:
rC Clang
https://reviews.llvm.org/D49911
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/S
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
The attribute itself is looking reasonable aside from some minor nits, but this
should not be committed until the clang-tidy functionality is approved (since
it has no utility be
mboehme marked 3 inline comments as done.
mboehme added a comment.
> Should this attribute have some semantic checking that ensures the non-static
> data members are accessed in the function that claims it reinitializes the
> object?
I think this would be hard to do in a way that provides meani
mboehme updated this revision to Diff 158051.
mboehme added a comment.
Various changes in response to reviewer comments.
Repository:
rC Clang
https://reviews.llvm.org/D49911
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/Sema/SemaDeclAttr.cpp
test/SemaCXX/attr
aaron.ballman added a comment.
Should this attribute have some semantic checking that ensures the non-static
data members are accessed in the function that claims it reinitializes the
object? Otherwise, it seems like this would not trigger any diagnostics:
class C {
int a, b;
public:
mboehme created this revision.
Herald added a subscriber: cfe-commits.
This is for use by clang-tidy's bugprone-use-after-move check -- see
corresponding clang-tidy patch at https://reviews.llvm.org/D49910.
Repository:
rC Clang
https://reviews.llvm.org/D49911
Files:
include/clang/Basic/Att
