[PATCH] D49898: Make test/Driver/baremetal.cpp work with linkers other than lld

2018-07-30 Thread David Greene via Phabricator via cfe-commits
greened closed this revision. greened added a comment. Committed in 338290. Repository: rC Clang https://reviews.llvm.org/D49898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49898: Make test/Driver/baremetal.cpp work with linkers other than lld

2018-07-30 Thread David Greene via Phabricator via cfe-commits
greened added a comment. I think I need an accept before this can proceed. Repository: rC Clang https://reviews.llvm.org/D49898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D49898: Make test/Driver/baremetal.cpp work with linkers other than lld

2018-07-27 Thread Jon Roelofs via cfe-commits
LGTM Jon On Thu, Jul 26, 2018 at 10:12 PM David Greene via Phabricator < revi...@reviews.llvm.org> wrote: > greened created this revision. > greened added reviewers: jroelofs, hans, probinson, ismail, rtrieu. > Herald added a subscriber: cfe-commits. > > This test fails if clang is configure wit

[PATCH] D49898: Make test/Driver/baremetal.cpp work with linkers other than lld

2018-07-26 Thread David Greene via Phabricator via cfe-commits
greened created this revision. greened added reviewers: jroelofs, hans, probinson, ismail, rtrieu. Herald added a subscriber: cfe-commits. This test fails if clang is configure with, for example, gold as the default linker. It does not appear that this test really relies on lld so make the chec